Standardise repo per module template as of April 2023 #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
commented
Apr 24, 2023
| // after the provider has processed the request, to ensure that the | ||
| // provider recognizes the id. | ||
| setImmediate(() => | ||
| setTimeout(() => |
There was a problem hiding this comment.
setImmediate is not available in recent versions of Node.js and/or browsers, so I've swapped this out to use setTimeout. For our purposes, it does effectively the same.
Mrtenz
commented
Apr 24, 2023
| @@ -298,6 +308,7 @@ export class MetaMaskInpageProvider extends AbstractStreamProvider { | |||
| */ | |||
| send<T>(payload: SendSyncJsonRpcRequest): JsonRpcResponse<T>; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/promise-function-async | |||
There was a problem hiding this comment.
send can return a Promise, so ESLint wants to add async to it. This changes the behaviour of the function, however, as anything would make it return a Promise. To avoid this we have to suppress this rule here.
|
Please document the breaking changes in this PR in the description. |
FrederikBolding
requested changes
Apr 24, 2023
Gudahtt
reviewed
Apr 24, 2023
Mrtenz
force-pushed
the
mrtenz/standardise-april-2023
branch
from
8048d34
to
ba7f3a5
Compare
FrederikBolding
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the repo to the latest standards. This includes a bump to the ESLint configurations, meaning I had to fix a bunch of ESLint-related errors.
Breaking changes